This repository has been archived by the owner on May 4, 2024. It is now read-only.
Hijack attr methods with hijack_attr_methods option
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because TracePoint doesn't support tracking attribute reader/writer methods (which is a bug), those method calls are currently undetectable. However, in most cases, we should still be able to track them by overriding the generated methods with normal method definition. But since this mutates the object's interfaces directly, it can still cause unexpected issues. So the behavior needs to be activated explicitly with the `hijack_attr_methods` option.
st0012
force-pushed
the
hijack_attr_methods
branch
from
da737f9
to
9c5c255
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
TracePointdoesn't track methods generated byattr_*helpers (see this issue for more info), we need to redefine those methods with the normal method definition.This hack is disabled for most of the trackers by default, as the side-effect remains unclear. But mutation related helpers like
tap_mutation!orprint_mutations.