-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Obsidian SRS ignores more than one tag #495
Comments
Hi @putzwasser @pikatwinky @MostlyArmless I might be able to look at the merge conflict #506, but first have a note regarding functionality.
From a look at the PR, all questions will be included in the complete set of decks There would be an argument for the following deck assignment: However, this would be different to what is in the PR, (and harder to implement). Also, not sure if the PR handles multiple inline tags within a question, such as:
Cheers |
Hi Ronny!
In my humble opinion, I see the usefulness of this PR, for the time being, as long as (following your example) once you review |
Hi @putzwasser, I agree about...
Regarding counting, I suggest that the card is included in each deck in which it is tagged. However it should only be counted once for any decks that are common ancestors. For example:
I.e. question1 would be counted once in each of the following decks:
Specifically, not counted twice for @MostlyArmless how is pull request #506 going? I might be able to work on this if you are too busy Regards |
Hi @MostlyArmless. Are you ok with @ronzulu solving the #506 merge conflicts? Thanks for your kindly help Ronny, i think this overlapping functionality is gonna be an amazing addition to this fantastic plugin |
@pikatwinky @ronzulu yes, if you have time to resolve the merge conflicts please go ahead I haven't had time to fix them myself due to the holidays. |
Actually, it's a little more involved than we thought, because questions can have their own question specific tags. So for example:
The existing functionality would have:
But if we simply look for all tags in the note then
This means that we can't use the obsidian function Fortunately there appears to be richer tag info available from: The location info within TagCache will need to be compared with info from the parser to determine if a tag is question specific or not. This will take more time to implement... Cheers |
Hi all, I have completed the update but would appreciate beta testing and feedback before I finalise the PR. The draft PR together with the updated code is available at: Cheers |
… (#834) * First bit of implementation * Slight refactor of parse() * Enhanced parser to return first and last line numbers * Finished impl for enhanced parsing for multiple topics per note, updated existing test cases (haven't fixed main.js or added all needed test cases) * Implementation & testing continuing * Comment change * pnpm format; updated changelog.md * pnpm lint * Need to rerun lint after format, and rerun format after lint * Updated flashcard user documentation * Added code to access the frontmatter tags * Fixed test cases after merging with #815 * lint & format * Fixed unit test case * Minor * Minor post merge fix * Lint * Fixed test case --------- Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>
Released into 1.12.0 |
Now, unrelated tags are shown as well, which makes the whole appearance a bit messy. E.g. my tag for marking flashcards is "#flashcard", but sometimes there are a couple other unrelated tags added to the note, like date tags and so on. Now the UI is clustered with all unrelated tags as well, not only the #flashcard tag and its sub-tags (#flashcard/sub1). |
Thanks for reporting this, but I can't reproduce the problem. Please open a new issue and post your markdown file (attachment, not copy/paste), as well as a screenshot of the card selection modal. I assume when you say "Now the UI is clustered..." the card selection modal is what you mean. Also please post your settings file, e.g.: Cheers |
Describe the bug
Obsidian SRS ignores more than one tag. It seems as if the algorithm stops assigning a card/note to decks after it matched the first tag it knows.
To Reproduce
otherFlashcardTag
to the list of flashcard tags.flashcard
only.Expected behavior
The card should be IMHO filed under
flashcard
flashcard/test
flashcard/test2
andotherFlashcardTag
I would at least expect the card to filed under
flashcard
andotherFlashcardTag
. It would be best if it belonged to all three decks.Use case: A flashcard for marketing that is about market research and customer behaviour.
I'd file the card under
#marketing/marketResearch
and#marketing/customerBehaviour
and maybecognitiveBias
. So, I'd like to study the card if I study themarketing/marketResearch
or themarketing/customerBehaviour
deck or the wholemarketing
deck if got a lot of time. Furthermore I'd like to see the card if I studycognitiveBias
es.Screenshots
Shows the file and that it only belongs to the
flashcard
deck.List of tags
Versions (please complete the following information):
Manjaro Linux
v0.15.9
v1.8.0
5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/0.15.9 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
The text was updated successfully, but these errors were encountered: