Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Multiple different cards on one page. If you don't have enough notes to separate the pages #705

Closed
DudeThatsErin opened this issue Jul 10, 2023 · 4 comments
Labels
enhancement New feature or request
Projects

Comments

@DudeThatsErin
Copy link

Is your feature request related to a problem? Please describe.
Not a problem. Just a FR

Describe the solution you'd like
I have this page that is very small.
image
It would be cool if I could have each header separated by something (idk what) so that I could have separate decks of flash cards all on one page instead of having to create separate pages for each deck.

@DudeThatsErin DudeThatsErin added the enhancement New feature or request label Jul 10, 2023
@ronzulu
Copy link
Collaborator

ronzulu commented Sep 11, 2023

Hi

I don't know if this helps, but you can add OSR tags to individual questions.

I'm assuming in your example above #webforms and #mvc are for non-OSR purposes.

So you could have (in the same note):
#flashcards/webforms Q1::A1
#flashcards/mvc Q2::A2

These will be presented by OSR in two separate decks.

Cheers
Ronny

@4Source
Copy link
Contributor

4Source commented Jan 10, 2024

Hi

I don't know if this helps, but you can add OSR tags to individual questions.

I'm assuming in your example above #webforms and #mvc are for non-OSR purposes.

So you could have (in the same note): #flashcards/webforms Q1::A1 #flashcards/mvc Q2::A2

These will be presented by OSR in two separate decks.

Cheers Ronny

Would be nice if this feature would be ment in the wiki.

But i agree it would be useful that you can define a block for flashcards deck that the flashcards in this block belong to this deck. If you have a bunch of different deck in a file and for each a lot of flashcards it is anoying to write every time the OSR.

I think best option is to use headings and tags e.g.

# #Deck1
Question in Deck1:: Answer in Deck1
Question2 in Deck1:: Answer2 in Deck1
# #Deck2
Question in Deck2:: Answer in Deck2
Question2 in Deck2:: Answer2 in Deck2

@ronzulu
Copy link
Collaborator

ronzulu commented Jan 12, 2024

Hi @DudeThatsErin

Hi all, I have completed the update but would appreciate beta testing and feedback before I finalise the PR.

The draft PR together with the updated code is available at:
#834

@4Source, good point:

Would be nice if this feature would be ment in the wiki.

Cheers
Ronny

@st3v3nmw st3v3nmw added this to To do in Roadmap via automation Jan 16, 2024
@st3v3nmw st3v3nmw moved this from To do to In progress in Roadmap Jan 16, 2024
st3v3nmw added a commit that referenced this issue Mar 9, 2024
… (#834)

* First bit of implementation

* Slight refactor of parse()

* Enhanced parser to return first and last line numbers

* Finished impl for enhanced parsing for multiple topics per note, updated existing test cases (haven't fixed main.js or added all needed test cases)

* Implementation & testing continuing

* Comment change

* pnpm format; updated changelog.md

* pnpm lint

* Need to rerun lint after format, and rerun format after lint

* Updated flashcard user documentation

* Added code to access the frontmatter tags

* Fixed test cases after merging with #815

* lint & format

* Fixed unit test case

* Minor

* Minor post merge fix

* Lint

* Fixed test case

---------

Co-authored-by: Stephen Mwangi <mail@stephenmwangi.com>
@st3v3nmw st3v3nmw moved this from In progress to Done (available in next release) in Roadmap Mar 9, 2024
@ronzulu
Copy link
Collaborator

ronzulu commented Mar 19, 2024

Released into 1.12.0

@ronzulu ronzulu closed this as completed Mar 19, 2024
@st3v3nmw st3v3nmw moved this from Done (available in next release) to Shipped! in Roadmap Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Roadmap
Shipped!
Development

No branches or pull requests

3 participants