Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back on item search in CollectionClient #379

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Dec 13, 2022

Related Issue(s):

Description:

Fall back on item search if features isn't implemented for a collection client.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to the CHANGELOG

@gadomski gadomski changed the title feat: fall back on item search Fall back on item search in CollectionClient Dec 13, 2022
@gadomski gadomski added this to the 0.5.2 milestone Dec 13, 2022
@gadomski gadomski self-assigned this Dec 30, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 85.05% // Head: 85.54% // Increases project coverage by +0.48% 🎉

Coverage data is based on head (1825895) compared to base (00e4c98).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   85.05%   85.54%   +0.48%     
==========================================
  Files          11       11              
  Lines         823      830       +7     
==========================================
+ Hits          700      710      +10     
+ Misses        123      120       -3     
Impacted Files Coverage Δ
pystac_client/collection_client.py 82.35% <90.00%> (+0.38%) ⬆️
pystac_client/stac_api_io.py 90.35% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the get_item method description needs to be updated to reflect the additional logic

pystac_client/collection_client.py Outdated Show resolved Hide resolved
pystac_client/collection_client.py Show resolved Hide resolved
@gadomski gadomski force-pushed the issues/236-get-item-with-search branch 2 times, most recently from cf85ca1 to e65d4ef Compare January 20, 2023 19:44
@gadomski gadomski force-pushed the issues/236-get-item-with-search branch from e65d4ef to e9b8dcf Compare January 20, 2023 19:49
@gadomski gadomski merged commit 0c8f738 into main Jan 20, 2023
@gadomski gadomski deleted the issues/236-get-item-with-search branch January 20, 2023 20:11
@pjhartzell pjhartzell mentioned this pull request Jan 27, 2023
3 tasks
@gadomski gadomski modified the milestones: 0.5.2, 0.6.0 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections get_item could also search if supported
3 participants