-
Couldn't load subscription status.
- Fork 56
Release v0.6.0 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.6.0 #413
Conversation
Codecov ReportBase: 86.12% // Head: 86.12% // No change to project coverage 👍
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 11 11
Lines 829 829
=======================================
Hits 714 714
Misses 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a missing item = assignment in collection_client.py from #379:
pystac-client/pystac_client/collection_client.py
Lines 172 to 173 in c8e2ef3
| else: | |
| super().get_item(id, recursive=True) |
|
@philvarner Per your comment a few months ago about dropping Python 3.7, what are your thoughts about including the drop in this minor release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending question about dropping Python 3.7 in this minor release.
I think It would be better just to do a 0.6.0 release rather than put it in a < 1.0.0 patch/minor release. |
Result wasn't being assigned and the line wasn't covered by the tests.
0ac38c3 to
8f73953
Compare
|
PR updated to v0.6.0, and I've updated our milestones as well to reflect the bump: https://github.com/stac-utils/pystac-client/milestones. |
Release notes:
PR Checklist: