do not index proj:geometry and proj:centroid as geo fields

[StijnCaerts]

Related Issue(s):

• proj:* cannot be indexed as geo field #154

Description:
Do not index proj:geometry and proj:centroid as geo fields.

PR Checklist:

• Code is formatted and linted (run pre-commit run --all-files)
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable
• Changes are added to the changelog

[jonhealy1]

LGTM thanks

[philvarner]

Could you describe more why this is a problem? We're doing this same thing in stac-server (where this was copied from) and it's working fine.

[jonhealy1]

Could you describe more why this is a problem? We're doing this same thing in stac-server (where this was copied from) and it's working fine.

It could be better if fewer fields were being indexed.

[philvarner]

That might be the case, but for these, eventually implementing the Aggregation Extension will allow geoaggregations like geohex to be done over proj:centroid and bucket aggregation over grid;code.

[jonhealy1]

It makes sense to keep the indexing if it will be used. How do you feel about the point that was made saying that only WGS-84 is supported by es?

[philvarner]

ah, good point. proj:geometry should not be indexed like this for that reason -- I'll fix that in stac-server also. However, proj:centroid is supposed to be WGS84 lat/lon, though neither the Projection Extension nor the Elasticsearch geo_point documentation state that it must be WGS84 :(

[StijnCaerts]

I restored the mapping of the proj:centroid field to geo_point according to your feedback.