-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not index proj:geometry and proj:centroid as geo fields #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe more why this is a problem? We're doing this same thing in stac-server (where this was copied from) and it's working fine.
It could be better if fewer fields were being indexed. |
That might be the case, but for these, eventually implementing the Aggregation Extension will allow geoaggregations like geohex to be done over proj:centroid and bucket aggregation over grid;code. |
It makes sense to keep the indexing if it will be used. How do you feel about the point that was made saying that only WGS-84 is supported by es? |
ah, good point. |
I restored the mapping of the |
Co-authored-by: Phil Varner <pvarner@element84.com>
Related Issue(s):
Description:
Do not index
proj:geometry
andproj:centroid
as geo fields.PR Checklist:
pre-commit run --all-files
)make test
)