Update pgstac to return 400 on invalid date parameter. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow backends to raise their own InvalidQueryParameter exceptions, which will be translated into a 400 by exception handling. This is another option for backends that want to handle query parameter validation in other ways besides stac-pydantic model validation.
lossyrob
force-pushed
the
fix/rde/invalid-date-400
branch
from
7e689e6
to
05aed8c
Compare
moradology
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgstac currently returns a 500 with an invalid date; this PR modifies this to return a 400.
Also allow backends to raise their own InvalidQueryParameter exceptions, which will be translated into a 400 by exception handling. This is another option for backends that want to handle query parameter validation in other ways besides stac-pydantic model validation.
This line in the pgstac search model indicates that validation is done outside of the pydantic model, but there were instances of
asyncpg.exceptions.InvalidDatetimeFormatErrorbeing thrown for bad datetime parameters. We could solve this by removing the overridden validator, but I'm not sure why this was overridden and also I think it's useful to provide a non-pydantic mechanism for backends to indicate parameters are invalid and having stac-fastapi return the right status code.