-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support collection list with top level links property #81
Support collection list with top level links property #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 96.38% 96.25% -0.13%
==========================================
Files 19 20 +1
Lines 442 454 +12
==========================================
+ Hits 426 437 +11
- Misses 16 17 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@moradology LGTM, can you run the pre-commit formatter on it so it passes CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
c4cf005
to
ab53906
Compare
I believe a maintainer will have to pull the trigger on this one as I lack write access to this repo. Perhaps there's a better place for this question but, as the changes here will be useful for a slight modification to |
ab53906
to
15b361c
Compare
9386a05
to
4a45f0a
Compare
I think CI should succeed here. |
@moradology CI was re-rerun...perhaps this is an issue with the version of black? |
84a663e
to
dacee38
Compare
@lossyrob Your guess about versions was on the money: |
The OGC standards seem to suggest that a top-level
links
property should be supported by the/collections
endpoint. This PR adds a class to support this slightly more sophisticated list of collections. This change would be useful e.g. here: https://github.com/stac-utils/stac-fastapi/blob/master/stac_fastapi/api/stac_fastapi/api/app.py#L154