Reorganize packaging #111
Merged
Reorganize packaging #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 11, 2021
Merged
gadomski
requested review from
lossyrob and
matthewhanson
and removed request for
lossyrob
|
@matthewhanson (and anyone else reviewing), if you can take and extra look at https://github.com/stac-utils/stactools/pull/111/files#diff-2e3c7d1bc0706a094cc1cac241569dd21973b559d51dd45b0640ef1ee7600e29 during the review, this is some of the tomfoolery I had to do to get the test path stuff working. |
jbants
reviewed
Jun 9, 2021
cuttlefish
reviewed
Jun 10, 2021
gadomski
added a commit
to stactools-packages/template
that referenced
this pull request
Jun 10, 2021
This was referenced Jun 10, 2021
matthewhanson
approved these changes
Jun 10, 2021
jbants
approved these changes
Jun 10, 2021
cuttlefish
approved these changes
Jun 10, 2021
- Removes all subpackages other than `core` and `cli` - Moves code into a more traditional package namespace structure in `src` - Switches to a static `setup.cfg` file - Adds more CI, including actually testing the Python matrix - Updates .gitignore - Updates README
This allows packages to use test utils without having to copy the code directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a major edit of the stactools packaging story. By splitting off packages into their own repositories, we:
stactools.core.Overview
stactools_browse. These packages are being moved to their own repositories in thestactools-packagesorganization.environment.ymlfile and instructions on runningstactoolswith conda.stactools.testingmodule with some testing helper functions to be used by other stactools packages.Other effects
git clone https://github.com/stac-utils/stactools && cd stactools && pip install -e .now works.clickis now a direct dependency ofstactools. Because every dataset subpackage hadclickas a dependency, it seemed like the use-case for aclick-less install (just using thestactools.coreAPI without any CLI or dataset subpackages) was vanishingly small.src/stactools, which is the recommended way to do same-repo namespace packages.Path forward
Once this PR is reviewed and approved, I hope to merge it then cut a v0.2.0-alpha.0 release. This release can then be used by packages to get their CI passing.