Use core's utilities in subpackages #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fails due to a bad `cogify` call in cgls_lc100. Also, adds a subsetted local file to make sure we don't run the tests forever when we do fix `cogify`.
- Adds `stactools.core.utils.convert.cogify` - Uses `cogify` and `call` from core when possible instead of defining custom calls in subpackages
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 84.94% 85.20% +0.25%
==========================================
Files 81 82 +1
Lines 2471 2453 -18
==========================================
- Hits 2099 2090 -9
+ Misses 372 363 -9
Continue to review full report at Codecov.
|
lossyrob
approved these changes
Jun 2, 2021
| # DEALINGS IN THE SOFTWARE. | ||
| # ***************************************************************************** | ||
|
|
||
| import os.path |
There was a problem hiding this comment.
Is there not a way to bring this in as a dependency rather than copy the code in?
There was a problem hiding this comment.
I didn't find a pip package for it, the Proper Ecosystem Thing™ would probably be to PR https://github.com/rouault/cog_validator w/ pip support. But for now this was the best way I could think of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of the dataset subpackages had defined their own
calland/orcogifyfunctions which do more or less the same thing. This pull request addsstactools.core.utils.convert.cogifyand updates subpackages to use core'scallandcogifyinstead of their own. The corecogifyfunction has sensible defaults (right now justdeflatecompression).When implementing, I discovered that
cgls_lc100'scogifywas broken due to a dangling'-co'option. As part of the fix, I updatedcgls_lc100's test file to a subset of the original external file, since it was mondo and cogifying it was taking forever.Also includes a small typo fix in README.