Fix EigenToPy/EigenFromPy on Windows #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
force-pushed
the
topic/fix_eigen_tofrom_py
branch
from
cd9d19b
to
1c9deea
Compare
…pecialization on Windows core: Use same namespace scope
for more information, see https://pre-commit.ci
jorisv
force-pushed
the
topic/fix_eigen_tofrom_py
branch
from
557fdcd
to
8f30722
Compare
jcarpent
approved these changes
Apr 24, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Jun 6, 2024
Updates:
## [3.6.0] - 2024-06-05
### Added
- Added a deprecation call policy shortcut ([466](stack-of-tasks/eigenpy#466))
### Fixed
- Fix register_symbolic_link_to_registered_type() for multiple successive registrations ([471](stack-of-tasks/eigenpy#471))
## [3.5.1] - 2024-04-25
### Fixed
- Allow EigenToPy/EigenFromPy specialization with CL compiler ([462](stack-of-tasks/eigenpy#462))
- Fix missing include for boost >= 1.85 ([464](stack-of-tasks/eigenpy#464))
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Jun 20, 2024
Updates:
## [3.6.0] - 2024-06-05
### Added
- Added a deprecation call policy shortcut ([466](stack-of-tasks/eigenpy#466))
### Fixed
- Fix register_symbolic_link_to_registered_type() for multiple successive registrations ([471](stack-of-tasks/eigenpy#471))
## [3.5.1] - 2024-04-25
### Fixed
- Allow EigenToPy/EigenFromPy specialization with CL compiler ([462](stack-of-tasks/eigenpy#462))
- Fix missing include for boost >= 1.85 ([464](stack-of-tasks/eigenpy#464))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows EigenToPy/EigenFromPy are not defined (only specialized) to avoid a CL compiler issue.
If we make the following declaration:
CL complain that MatType is an undeclared identifier.
To avoid that, a first hack was to not define but only specialize EigenToPy (same for EigenFromPy) on Windows:
Unfortunately, this hack prevent to specialize EigenToPy for custom scalar type with CL.
This PR revert this hack and fix the first issue by moving the default Scalar definition in the EigenToPy definition.