Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test multiple_registration, fix register_symbolic_link_to_registered_type() for multiple successive registrations #471

Merged

Conversation

ManifoldFR
Copy link
Member

  • added a unit test where I expose the same class multiple times with the register_symbolic_link_to_registered_type() safeguard, it currently produces a wonderful 36 errors :D
  • add a missing incref in register_symbolic_link_to_registered_type() (thanks @jcarpent)

Here's the valgrind report without the fix:
report.log

+ currently produces a wonderful 36 errors :D
@ManifoldFR ManifoldFR requested a review from jorisv May 22, 2024 17:35
@ManifoldFR ManifoldFR merged commit 3ab149b into stack-of-tasks:devel May 22, 2024
29 checks passed
@ManifoldFR ManifoldFR deleted the topic/fix-register-symbolic-link branch May 22, 2024 18:18
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jun 6, 2024
Updates:
    ## [3.6.0] - 2024-06-05

    ### Added
    - Added a deprecation call policy shortcut ([466](stack-of-tasks/eigenpy#466))

    ### Fixed
    - Fix register_symbolic_link_to_registered_type() for multiple successive registrations ([471](stack-of-tasks/eigenpy#471))

    ## [3.5.1] - 2024-04-25

    ### Fixed
    - Allow EigenToPy/EigenFromPy specialization with CL compiler ([462](stack-of-tasks/eigenpy#462))
    - Fix missing include for boost >= 1.85  ([464](stack-of-tasks/eigenpy#464))
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jun 20, 2024
Updates:
    ## [3.6.0] - 2024-06-05

    ### Added
    - Added a deprecation call policy shortcut ([466](stack-of-tasks/eigenpy#466))

    ### Fixed
    - Fix register_symbolic_link_to_registered_type() for multiple successive registrations ([471](stack-of-tasks/eigenpy#471))

    ## [3.5.1] - 2024-04-25

    ### Fixed
    - Allow EigenToPy/EigenFromPy specialization with CL compiler ([462](stack-of-tasks/eigenpy#462))
    - Fix missing include for boost >= 1.85  ([464](stack-of-tasks/eigenpy#464))
nim65s added a commit to nim65s/robotpkg that referenced this pull request Jul 1, 2024
Updates:
    ## [3.6.0] - 2024-06-05

    ### Added
    - Added a deprecation call policy shortcut ([466](stack-of-tasks/eigenpy#466))

    ### Fixed
    - Fix register_symbolic_link_to_registered_type() for multiple successive registrations ([471](stack-of-tasks/eigenpy#471))

    ## [3.5.1] - 2024-04-25

    ### Fixed
    - Allow EigenToPy/EigenFromPy specialization with CL compiler ([462](stack-of-tasks/eigenpy#462))
    - Fix missing include for boost >= 1.85  ([464](stack-of-tasks/eigenpy#464))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants