Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panda3d viewer is broken in examples #1189

Closed
cmastalli opened this issue Apr 28, 2020 · 5 comments
Closed

Panda3d viewer is broken in examples #1189

cmastalli opened this issue Apr 28, 2020 · 5 comments

Comments

@cmastalli
Copy link
Member

For more details see #1183 (review)
@gabrielebndn
Copy link
Contributor

The viewer isn't broken. The examples are broken. This is because they try to import Panda3dViewer (an alias of Viewer) and ViewerClosedError from pinocchio.visualize.panda3d_visualize, but they are not there any more. I think the changes in #1183 were correct and the solution to fix the examples is simple: just import Viewer and ViewerClosedError directly from panda3d_viewer.

@cmastalli
Copy link
Member Author

Thanks for the clarification. Indeed, I wasn't sure about this point.

@ikalevatykh
Copy link
Contributor

@cmastalli , it is not a good idea to "fix" working code ;)

This was referenced Apr 29, 2020
Closed
Merged
@cmastalli
Copy link
Member Author

cmastalli commented Apr 29, 2020 •
edited
Loading

@ikalevatykh I didn't modify that part of code. I just fixed the installation of the files. You could check the git history for details.

@jcarpent
Copy link
Contributor

Solved by #1191.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcarpent @cmastalli @gabrielebndn @ikalevatykh