Fix panda3d installation and example #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
reviewed
Apr 24, 2020
wxmerkt
reviewed
Apr 24, 2020
cmastalli
force-pushed
the
topic/fix-panda3d-stuff
branch
from
f85e6b6
to
842a254
Compare
cmastalli
commented
Apr 28, 2020
| @@ -121,3 +117,5 @@ def displayVisuals(self, visibility): | |||
| """Set whether to display visual objects or not.""" | |||
| self.viewer.show_group(self.visual_group, visibility) | |||
| self.display_visuals = visibility | |||
|
|
|||
| __all__ = ['Panda3dVisualizer'] | |||
There was a problem hiding this comment.
@jcarpent removing Panda3dViewer from __all__ breaks the examples written in Pinocchio.
I am not familiar with the code, but it seems we need to put back the previous __all___ definition.
There was a problem hiding this comment.
@cmastalli @ikalevatykh The changes are relevant, as panda3d_viewer may not be available. Then, you cannot import the lib, otherwise, you will get an error.
There was a problem hiding this comment.
@jcarpent Original variant was also OK as panda3d_visualize was not imported in visualize. _import_. Just to clarify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title is self-explanatory :)