Update old function, remove mobile robot wrapper #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. |
|
Oh. Okay, I get it. In MobileRobot instead of call super.init I should call initFromUrdf. But actually I don't know the final result. Is it okay that robot could slide away from mobile platform ? |
|
I'm on holiday today and tomorrow, I'll be able to look at it Monday |
proyan
reviewed
Aug 18, 2021
proyan
approved these changes
Aug 23, 2021
proyan
requested changes
Aug 23, 2021
Co-authored-by: Rohan Budhiraja <12423606+proyan@users.noreply.github.com>
proyan
approved these changes
Aug 23, 2021
|
Thanks @kozakromch for the contribution. |
jcarpent
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I try to do this exercise, but noticed that there are a lot of deprecated or not working function.
class mobileRobotWrapper not working, and I don't know how to fix it, so I remove it.