Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 release support #1681

Merged
merged 3 commits into from Aug 11, 2022
Merged

ROS2 release support #1681

merged 3 commits into from Aug 11, 2022

Conversation

wxmerkt
Copy link
Member

@wxmerkt wxmerkt commented Jun 16, 2022

WIP - testing branch to prepare a ROS2 release

@wxmerkt
Copy link
Member Author

wxmerkt commented Jun 16, 2022

Okay, this will take a bit more time - I need to recursively release eigenpy and hpp-fcl first. Will update this PR once ready.

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @wxmerkt for the support of ROS-2.

@wxmerkt wxmerkt mentioned this pull request Jul 18, 2022
@VladimirIvan
Copy link
Contributor

@wxmerkt @jcarpent just wanted say I'm very much looking to the release in the ROS2 ecosystem. Let me know if I can help with the testing.

@jcarpent
Copy link
Contributor

jcarpent commented Aug 2, 2022

@wxmerkt @jcarpent just wanted say I'm very much looking to the release in the ROS2 ecosystem. Let me know if I can help with the testing.

Thanks @VladimirIvan for your message. I'm finishing with #1723 and then I will provide a new release, hopefully today.

@wxmerkt wxmerkt marked this pull request as ready for review August 2, 2022 09:55
@wxmerkt
Copy link
Member Author

wxmerkt commented Aug 2, 2022

With #1720 merged and the recent release of EigenPy and HPP-FCL into all ROS2 distributions (bar Foxy for HPP-FCL for now), the CI should pass on this PR. Once it does, and once this one and #1723 are merged, we can make a release for ROS2.

@wxmerkt
Copy link
Member Author

wxmerkt commented Aug 2, 2022

There appears to be an issue with the environment hooks and I will have to make amendments to eigenpy, hpp-fcl. and pinocchio or patch all releases. This will require some time, so my guess would be either late this week or next week for me to get to this [each distro has to be patched individually]

@jcarpent
Copy link
Contributor

jcarpent commented Aug 2, 2022

@wxmerkt Should I proceed to a release?

@wxmerkt
Copy link
Member Author

wxmerkt commented Aug 2, 2022

Let's wait until ros/rosdistro#34041 and ros/rosdistro#34040 are merged and available, then restart the failed rolling-CI job of this PR, then merge this PR, then make a release :-)

[And if this resolves the issue, then I will also manually patch the other distributions]

@nim65s
Copy link
Contributor

nim65s commented Aug 8, 2022

Hi,

We now have issues with an undefined bash variable on colcon jobs:


after_run_target_test
  
  $ ( source /root/target_ws/install/setup.bash && cd /root/target_ws/build/pinocchio && make test; )
  /root/target_ws/install/setup.bash: line 11: COLCON_TRACE: unbound variable
'after_run_target_test' returned with code '1' after 0 min 0 sec

@wxmerkt
Copy link
Member Author

wxmerkt commented Aug 8, 2022

I'm aware of the issue and waiting for my patched EigenPy/HPP-FCL to get merged upstream

@jcarpent
Copy link
Contributor

Fantastic @wxmerkt. Thanks a lot.

@jcarpent jcarpent merged commit bebd4c2 into devel Aug 11, 2022
@wxmerkt wxmerkt deleted the topic/ros2-release branch August 15, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants