Fix CMake install path #2202
Fix CMake install path #2202
Conversation
CMakeLists.txt
Outdated
| FOREACH(boostlib ${BOOST_REQUIRED_COMPONENTS}) | ||
| PKG_CONFIG_APPEND_LIBS("boost_${boostlib}") | ||
| ENDFOREACH(boostlib ${BOOST_REQUIRED_COMPONENTS}) | ||
| # PKG_CONFIG_APPEND_BOOST_LIBS(${BOOST_REQUIRED_COMPONENTS}) |
There was a problem hiding this comment.
Should we change the jrl cmakemodule directly?
There was a problem hiding this comment.
Why this change?
Because the aboslute path is only present, after the other change, because boost::filesystem is not header only, and so to still link on all components, without having -L/path it's the only solution i saw.
There was a problem hiding this comment.
Could you remove the commented line?
There was a problem hiding this comment.
for cmeel packaging, which also avoid full paths, those are simply removed for now.
A better solution would be to have a side project properly writing .pc files for boost, in a clean way. I started something in this direction 2y ago, but didn't went very far.
src/CMakeLists.txt
Outdated
| SET_TARGET_PROPERTIES(${PROJECT_NAME} PROPERTIES LINKER_LANGUAGE CXX INSTALL_RPATH "\$ORIGIN") | ||
|
|
There was a problem hiding this comment.
Please do not commit this change as it is not related to the topic of this PR.
There was a problem hiding this comment.
Could you please undo this change ?
There was a problem hiding this comment.
Sorry will do it again
CMakeLists.txt
Outdated
| FOREACH(boostlib ${BOOST_REQUIRED_COMPONENTS}) | ||
| PKG_CONFIG_APPEND_LIBS("boost_${boostlib}") | ||
| ENDFOREACH(boostlib ${BOOST_REQUIRED_COMPONENTS}) | ||
| # PKG_CONFIG_APPEND_BOOST_LIBS(${BOOST_REQUIRED_COMPONENTS}) |
There was a problem hiding this comment.
Should we change the jrl cmakemodule directly?
Revert
|
@MegMll You are still missing the important change that you removed by force-pushing. |
Fix issue in #2187.
Probably does not work in case boost and pinocchio are not installed in the directory.