Always suppose hpp-fcl Python binding are present when hpp-fcl C++ library is found #2288
Conversation
… C++ library is found Pinocchio Python binding needs hpp-fcl Python binding for collision/contact related algorithms. We allow with the `BUILD_WITH_HPP_FCL_PYTHON_BINDINGS` CMake variable to build Pinocchio C++ library with hpp-fcl but to ignore hpp-fcl in the Python bindings if the hpp-fcl Python bindings are not installed. This create the following issues: - To compute `BUILD_WITH_HPP_FCL_PYTHON_BINDINGS` we must call the Python interpreter. This create some issue when cross compiling. - We never test this case in our CI, so we don't know if this option is working. This PR remove this option to simplify the build. In the case an user build Pinocchio Python binding with hpp-fcl C++ library but without hpp-fcl binding, the Python interpreter will raise an ImportError.
jorisv
force-pushed
the
topic/simplify_hpp_fcl_bindings
branch
from
febb5d8
to
814c506
Compare
|
This seems sensible to me, noting the issues we've had over at the conda-forge feedstock with cross-building: https://github.com/conda-forge/pinocchio-feedstock/pull/117/checks?check_run_id=26326030013. We had a similar problem with getting proxsuite-nlp over on aarch64 and ppc due to the same check happening during crossbuilding. It would be perhaps better to check if the hpp-fcl Python bindings' CMake target exists, if we want to reintroduce a check like this in the future. |
I don't think we want to reintroduce this in the future. The build issues in conda-forge show this option was broken. We already have too much options in Pinocchio, and it's really hard to test all the combination. I also think this kind of issue should be managed by a package manager instead of CMake. |
Totally makes sense! I agree the combinatorics of all the options was too much. |
Pinocchio Python binding needs hpp-fcl Python binding for collision/contact related algorithms.
We allow with the
BUILD_WITH_HPP_FCL_PYTHON_BINDINGSCMake variable to build Pinocchio C++ library with hpp-fcl but to ignore hpp-fcl in the Python bindings if the hpp-fcl Python bindings are not installed.This create the following issues:
BUILD_WITH_HPP_FCL_PYTHON_BINDINGSwe must call the Python interpreter. This create some issues when cross compiling.This PR remove this option to simplify the build.
In the case an user build Pinocchio Python binding with hpp-fcl C++ library but without hpp-fcl binding, the Python interpreter will raise an ImportError.