CMake: modernize link to console_bridge #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
previously approved these changes
Jul 3, 2024
jorisv
reviewed
Jul 3, 2024
|
I have added the no changelog tag. But it could be nice to have an entry in the fixed section: Add CMake compatibility with old console_bridge version #2312 |
nim65s
force-pushed
the
modernize-console-bridge
branch
from
d37651b
to
06c61fc
Compare
jorisv
previously approved these changes
Jul 3, 2024
jcarpent
force-pushed
the
modernize-console-bridge
branch
from
7f28fcb
to
5bf0eef
Compare
|
@nim65s What is the status of this PR? |
|
My test was positive (build was fixed on NetBSD 9.0), so I guess this can be merged. Thanks for the heads-up :) |
jorisv
force-pushed
the
modernize-console-bridge
branch
2 times, most recently
from
5bf0eef
to
81b97e5
Compare
jorisv
force-pushed
the
modernize-console-bridge
branch
from
81b97e5
to
5a361cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This provide compatibility with older console_bridge versions.
This was not tested yet, so let's keep it as draft for now.