Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve link for Python examples #647

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Jan 21, 2019

I find pointing to the folder rather than the README.md is clearer. Note: you still see the README.md at the bottom of the page with the new link.

I was a bit confused when I clicked and only saw the README and thought "but where are the examples I wanted to look at?".

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4c0a680 on lesteve:patch-1 into f665f3f on stack-of-tasks:master.

@jcarpent
Copy link
Contributor

@lesteve Good to see you here! Thanks for this contribution.

@jcarpent jcarpent merged commit 01f211e into stack-of-tasks:master Jan 21, 2019
@lesteve
Copy link
Contributor Author

lesteve commented Jan 21, 2019

I realized you had a devel branch after I created the PR against master. I am guessing I should have targeted devel so maybe there is some cleanup you may want to do at one point.

You may consider adding a CONTRIBUTING.md file at the root of your repo for contribution guidelines. See this for more details.

@lesteve lesteve deleted the patch-1 branch January 21, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants