Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

Add cmake code to create library for c++ #6

Closed
wants to merge 1 commit into from

Conversation

andreadelprete
Copy link

Moreover, add missing include in src/stack-template.t.cpp

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 08632d3 on andreadelprete:master into 51a55f0 on stack-of-tasks:master.

PKG_CONFIG_USE_DEPENDENCY(${LIBRARY_NAME} sot-core)
PKG_CONFIG_USE_DEPENDENCY(${LIBRARY_NAME} dynamic-graph)
PKG_CONFIG_USE_DEPENDENCY(${LIBRARY_NAME} soth)
INSTALL(TARGETS ${LIBRARY_NAME} DESTINATION ${CMAKE_INSTALL_LIBDIR})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate a bit on your targeted application ?
Unless you want to move to a pure C++ implementation I am not sure to fully understand
the purpose of putting everything in one library.
Currently the fine granularity allows to avoid unnecessary binary dependencies.
Thanks to the huge work of Florent and Thomas, this is almost not noticeable in python.
So, I would like to fully understand your point of view before introducing a new linking system
likely to add noise in the comprehension of the overall system.

Best,
Olivier.

@andreadelprete
Copy link
Author

As you already guessed, I'd like to move to a pure C++ implementation. I find it much easier to reverse-engineer pure C++ code than a mix of C++ and python.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants