Add linear interpolation to go from the current posture to the first one in the stack #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proyan
reviewed
Feb 6, 2017
| @@ -33,12 +33,16 @@ namespace dynamicgraph | |||
| firstSINTERN( NULL, | |||
There was a problem hiding this comment.
Looks good to me. We don't need a dummy signal anymore. I will remove it.
|
It seems that I don't have permission to merge on sot-tools. Could you please merge it here? |
proyan
reviewed
Feb 6, 2017
| else | ||
| { | ||
| // Tries to go closer to the first posture. | ||
| deltapos = (deltapos * dt_)/time_to_start_; |
There was a problem hiding this comment.
it should be deltapos = deltapos/time_to_start_;, since we are already simulating the entity after every dt seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.