Fix python issue #50 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilienNaveau
approved these changes
Oct 12, 2019
| bp::object & bpObject, | ||
| bool verbose) | ||
| { | ||
| std::cout << "Before extraction " << std::endl; |
There was a problem hiding this comment.
Is this cout needed? Should it be protected with the verbose boolean?
| std::cout << "Before extraction " << std::endl; | ||
| pinocchio::JointModelFreeFlyer root_joint = | ||
| bp::extract<pinocchio::JointModelFreeFlyer>(bpObject)(); | ||
| std::cout << "After extraction " << std::endl; |
There was a problem hiding this comment.
Unfortunate oversight. Thanks for catching it
Thx to mnaveau for picking it.
|
The new commit is fixing the std::cout issue. |
|
I would say this PR is ready for merging. Thanks for the dev! |
|
Thanks for this PR @olivier-stasse ! |
NoelieRamuzat
pushed a commit
to NoelieRamuzat/tsid
that referenced
this pull request
Feb 18, 2020
Fix python glitch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to bindings/python/robots/robot-wrapper.hpp
to read a JointModelFreeFlyer python type and call the appropriate constructor of the RobotWrapper object.
It might be needed to extend this if someone wants to use another joint than a FreeFlyer as a root (but it looks unlikely to happen).