-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to external eiquadprog, fix #76 #87
Conversation
Sorry for previous PR it was against the wrong branch. |
You can edit the destination branch instead of close the PR and reopen it :) |
@nim65s Thanks for the tip. I saw that I could change the title, but not the targeted branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me!
Dear Andrea could you have a look to stack-of-tasks/eiquadprog#8 ? |
Dear @nim65s I merged stack-of-tasks/eiquadprog#8 so normally this PR can also be merged. |
The merge of this PR should wait a release release of eiquadprog. But the release of eiquadprog should wait for me to be able to run the integration tests of sot-talos-balance with it. This is currently blocked by other issues : stack-of-tasks/talos_integration_tests#5 |
This PR assumes that the PR stack-of-tasks/eiquadprog#8 on Eiquadprog has been accepted.
It removes the eigen quad prog solver that has been externalized by @gabrielebndn
The unit test have been validated.
If someone can check the jupyter notebooks and the examples this could be enough.