Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to external eiquadprog, fix #76 #87

Merged
merged 1 commit into from
May 26, 2020

Conversation

olivier-stasse
Copy link
Member

This PR assumes that the PR stack-of-tasks/eiquadprog#8 on Eiquadprog has been accepted.
It removes the eigen quad prog solver that has been externalized by @gabrielebndn
The unit test have been validated.
If someone can check the jupyter notebooks and the examples this could be enough.

@olivier-stasse
Copy link
Member Author

Sorry for previous PR it was against the wrong branch.

@nim65s
Copy link
Contributor

nim65s commented May 10, 2020

You can edit the destination branch instead of close the PR and reopen it :)
I'm marking this PR as draft, as it will have to wait a release of stack-of-tasks/eiquadprog#8

@nim65s nim65s marked this pull request as draft May 10, 2020 10:42
@olivier-stasse
Copy link
Member Author

@nim65s Thanks for the tip. I saw that I could change the title, but not the targeted branch.

Copy link
Collaborator

@andreadelprete andreadelprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me!

@olivier-stasse
Copy link
Member Author

Dear Andrea could you have a look to stack-of-tasks/eiquadprog#8 ?
The current PR cannot pass if the one on eiquadprog does not pass before, and I think @gabrielebndn is unfortunately not able to do the review.
It should be easy, as the work was done on what you had done in TSID.
Thanks a lot for your help.

@olivier-stasse
Copy link
Member Author

Dear @nim65s I merged stack-of-tasks/eiquadprog#8 so normally this PR can also be merged.
I let you do it according to the policy.

@nim65s nim65s self-assigned this May 14, 2020
@nim65s
Copy link
Contributor

nim65s commented May 15, 2020

The merge of this PR should wait a release release of eiquadprog. But the release of eiquadprog should wait for me to be able to run the integration tests of sot-talos-balance with it. This is currently blocked by other issues : stack-of-tasks/talos_integration_tests#5

@nim65s nim65s merged commit 6d42f61 into stack-of-tasks:devel May 26, 2020
@nim65s nim65s mentioned this pull request May 28, 2020
@nim65s nim65s changed the title Fix #76 as far as the tests are concerned. switch to external eiquadprog, fix #76 May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants