Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Default IP address is retrieved with nix instead of pnet #109

Merged
merged 1 commit into from Mar 11, 2021
Merged

Default IP address is retrieved with nix instead of pnet #109

merged 1 commit into from Mar 11, 2021

Conversation

siegfriedweber
Copy link
Member

Fixes #67

@siegfriedweber siegfriedweber requested a review from a team March 11, 2021 13:30
@siegfriedweber siegfriedweber added this to Review in progress in Stackable via automation Mar 11, 2021
@siegfriedweber siegfriedweber self-assigned this Mar 11, 2021
soenkeliebau
soenkeliebau previously approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stackable automation moved this from Review in progress to To be merged Mar 11, 2021
Stackable automation moved this from To be merged to Review in progress Mar 11, 2021
@siegfriedweber
Copy link
Member Author

I fixed #103 on upstream and this one on origin. I had to rebase this branch.

Stackable automation moved this from Review in progress to To be merged Mar 11, 2021
soenkeliebau
soenkeliebau approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just a brief look, I assume no changes apart from the rebase)

@siegfriedweber siegfriedweber merged commit a176a6c into stackabletech:main Mar 11, 2021
Stackable automation moved this from To be merged to Done Mar 11, 2021
@siegfriedweber siegfriedweber deleted the replace_pnet branch March 11, 2021 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@soenkeliebau soenkeliebau soenkeliebau approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
No open projects
Stackable
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2018-0015: term is looking for a new maintainer
2 participants
@siegfriedweber @soenkeliebau