Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Adds command line parameter to control the pod cidr the agent requests from Kubernetes #50

Merged
merged 6 commits into from
Feb 11, 2021
Merged

Adds command line parameter to control the pod cidr the agent requests from Kubernetes #50

merged 6 commits into from
Feb 11, 2021

Conversation

soenkeliebau
Copy link
Member

No description provided.

@soenkeliebau
Changed the pod cidr that our kubelet reports to the cluster to an em…
125a461 
…pty string, instead of the hard coded default of 10.244.0.0 which causes issues for clusters that have something else configured.

This should cause Kubernetes to assign a valid cidr from the configured range.
@soenkeliebau
Added command line parameter to control the setting of pod cidr range.
3b1476f 
Also changed the default for this value to an empty string.
@soenkeliebau
Reverted change that is already included in a PR in review.
bcfcdef
@soenkeliebau
Removed debug log
f508d6a
@soenkeliebau soenkeliebau requested a review from a team February 10, 2021 16:51
@lfrancke lfrancke linked an issue Feb 10, 2021 that may be closed by this pull request
Allow configuration of Pod CIDR Range #49
Closed
lfrancke
lfrancke previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, feel free to merge or change

src/config/config_documentation/pod_cidr.adoc Show resolved Hide resolved
src/config/mod.rs Outdated Show resolved Hide resolved
@lfrancke
Copy link
Member

There are a bunch of clippy warnings but I believe they are unrelated

@soenkeliebau
Copy link
Member Author

I've reverted the rust toolchain to stable so that the clippy check passes.
This pretty much perfectly illustrates the point I made in https://github.com/stackabletech/documentation/issues/43 about suddenly having random build failures that are not related to anything we did.

@lfrancke
Copy link
Member

In that case I propose we build on both stable and nightly where stable works. And then make only stable a required check

@soenkeliebau
Copy link
Member Author

But that wouldn't work for anything were we want backtrace enabled for example - which is the root cause of this discussion.

Can we pick a specific nightly version in the github action? Then we can update that every two weeks or so. That'll at least give us some predictability while still enabling to use nightly features.

@lfrancke lfrancke self-assigned this Feb 11, 2021
lfrancke
lfrancke approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more instance of ip->IP

src/config/mod.rs
@@ -164,7 +164,7 @@ impl AgentConfig {
default: Some(""),
required: false,
takes_argument: true,
help: "An ip range in CIDR notation which designates the range that pods assigned to this node should have their ip addresses in.",
help: "An IP range in CIDR notation which designates the range that pods assigned to this node should have their ip addresses in.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more "ip" in here.

@soenkeliebau soenkeliebau merged commit 6c1f260 into main Feb 11, 2021
@soenkeliebau soenkeliebau deleted the podcidr branch February 11, 2021 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfrancke lfrancke lfrancke approved these changes

Assignees

@lfrancke lfrancke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuration of Pod CIDR Range
2 participants
@soenkeliebau @lfrancke