OIDC AuthenticationClass ADR

[fhennig]

related:

• this demo of OIDC connectivity with a couple of products: OpenID & OPA PoC Demo stackablectl#283
• OpenID Connect epic: OpenID Connect issues#431

[netlify]

✅ Deploy Preview for stackable-docs ready!

Name	Link
🔨 Latest commit	8638844
🔍 Latest deploy log	https://app.netlify.com/sites/stackable-docs/deploys/6564be54708cf50008a2a48c
😎 Deploy Preview	https://deploy-preview-460--stackable-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[maltesander]

I tried to implement this on trino but could not get kube-rs to generate the correct CRD when flattening an optional enum (its always mandatory). Dont mind the names, just an example.

#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
#[serde(rename_all = "camelCase")]
pub struct TrinoAuthenticationClassRef {
    pub authentication_class: String,
    #[serde(flatten)]
    pub secret: Option<TrinoAuthenticationSecret>,
}

#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
#[serde(rename_all = "camelCase")]
pub enum TrinoAuthenticationSecret {
    Oidc {
        #[serde(rename = "clientCredentialsSecret")]
        client_credentials_secret: String,
    },
}

generates

                clusterConfig:
                  description: Trino cluster configuration options.
                  properties:
                    authentication:
                      default: []
                      description: Authentication options for Trino.
                      items:
                        oneOf:
                          - required:
                              - oidc
                        properties:
                          authenticationClass:
                            type: string
                          oidc:
                            properties:
                              clientCredentialsSecret:
                                type: string
                            required:
                              - clientCredentialsSecret
                            type: object
                        required:
                          - authenticationClass
                        type: object
                      type: array

Any ideas?

[NickLarsenNZ]

Thanks for the ADR updates @Techassi.
I have noted some things down that came to mind.

[adwk67]

Just some minor typos.

[fhennig]

Thanks @adwk67 !

[razvan]

lgtm

[NickLarsenNZ]

Just spotted two things, otherwise ok by me

[NickLarsenNZ]

Good to go