Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support for 24.0.0 #317

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Support for 24.0.0 #317

wants to merge 5 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Oct 13, 2022 •
edited
Loading

Description

  • Added 24.0.0

fixes #315

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/25/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander self-assigned this Oct 13, 2022
@maltesander maltesander marked this pull request as ready for review October 13, 2022 10:16
@maltesander maltesander requested a review from a team October 13, 2022 10:16
@razvan razvan requested review from razvan and removed request for a team October 13, 2022 12:31
razvan
razvan approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I would remove one zookeeper version from the test definition to reduce the chance of test flakiness.

@maltesander
Copy link
Member Author

lgtm

I would remove one zookeeper version from the test definition to reduce the chance of test flakiness.

There was one failed test (it had a timeout of 300s for druid install), i just went up to 600s (that was the max i found in the tests for all tests). Lets see what happens. Changed to zookeeper-latest in all tests but smoke.

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 13, 2022
@maltesander
Support for 24.0.0 (#317)
8e4e7ad 
# Description

- Added 24.0.0

fixes #315

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/25/



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support for 24.0.0 [Merged by Bors] - Support for 24.0.0 Oct 13, 2022
@bors bors bot closed this Oct 13, 2022
@bors bors bot deleted the support-version-24.0.0 branch October 13, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW VERSION] 24.0.X
2 participants
@maltesander @razvan