Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove field autoFormatFs, which was never read #422

Merged
merged 2 commits into from Nov 8, 2023
Merged

fix: Remove field autoFormatFs, which was never read #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
020a693
fix: Removed field autoFormatFs, which was never read
sbernauer Nov 8, 2023
b7f09f0
changelog
sbernauer Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -21,6 +21,7 @@ All notable changes to this project will be documented in this file.
### Fixed

- Don't default roleGroup replicas to zero when not specified ([#402]).
- [BREAKING] Removed field `autoFormatFs`, which was never read ([#422]).

### Removed

Expand All @@ -36,6 +37,7 @@ All notable changes to this project will be documented in this file.
[#405]: https://github.com/stackabletech/hdfs-operator/pull/405
[#407]: https://github.com/stackabletech/hdfs-operator/pull/407
[#409]: https://github.com/stackabletech/hdfs-operator/pull/409
[#422]: https://github.com/stackabletech/hdfs-operator/pull/422

## [23.7.0] - 2023-07-14

Expand Down
3 changes: 0 additions & 3 deletions deploy/helm/hdfs-operator/crds/crds.yaml
View file
Open in desktop
Expand Up @@ -46,9 +46,6 @@ spec:
required:
- kerberos
type: object
autoFormatFs:
nullable: true
type: boolean
dfsReplication:
default: 3
format: uint8
Expand Down
2 changes: 0 additions & 2 deletions rust/crd/src/lib.rs
View file
Open in desktop
Expand Up @@ -95,8 +95,6 @@ pub struct HdfsClusterSpec {
#[derive(Clone, Debug, Deserialize, Eq, Hash, JsonSchema, PartialEq, Serialize)]
#[serde(rename_all = "camelCase")]
pub struct HdfsClusterConfig {
// FIXME: This attribute does not seem to be read anywhere.
pub auto_format_fs: Option<bool>,
#[serde(default = "default_dfs_replication_factor")]
pub dfs_replication: u8,
/// Name of the Vector aggregator discovery ConfigMap.
Expand Down