Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove field autoFormatFs, which was never read #422

Merged
merged 2 commits into from Nov 8, 2023
Merged

fix: Remove field autoFormatFs, which was never read #422

merged 2 commits into from Nov 8, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 8, 2023 •
edited by lfrancke

Description

Fixes #399
There are no usages: https://github.com/search?q=org%3Astackabletech%20autoFormatFs&type=code

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Helm chart can be installed and deployed operator works
    Options
  4. Integration tests passed (for non trivial changes)
    Options
  5. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@sbernauer sbernauer self-assigned this Nov 8, 2023
@sbernauer sbernauer changed the title fix: Removed field autoFormatFs, which was never read fix: Remove field autoFormatFs, which was never read Nov 8, 2023
@sbernauer sbernauer added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit ff6010c Nov 8, 2023
30 checks passed
@sbernauer sbernauer deleted the fix/auto-format-fs-field branch November 8, 2023 09:25
@lfrancke lfrancke added changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label release/2023-11 labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@sbernauer sbernauer

Labels
changelog/crd-change Any issue that changes a CRD (breaking and non-breaking changes) should get this label release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field autoFormatFs is never read
3 participants
@sbernauer @Techassi @lfrancke