-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy userinfofetcher regorules #580
base: spike/bundle-builder-v2
Are you sure you want to change the base?
Conversation
"url": "http://127.0.0.1:9476/user", | ||
"body": {"username": username}, | ||
"headers": {"Content-Type": "application/json"}, | ||
"raise_error": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to mention that we other examples where we assert on the return code and don't use raise_error
:
https://github.com/stackabletech/demos/blob/61601f8ed879c4e8ba0766ec0fe0320ee959bdb7/stacks/end-to-end-security/trino-policies.yaml#L176-L184
I don't have any preference, but other ones might have and we should agree on one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Will there be (antora) docs in this PR?
Huhh I was convinced that I did.. but ideally yes there should be. |
There we go, turns out I had "just" forgotten to push them.. oops. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just one suggestion for the docs
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Description
Fixes #558 by always including static rules with the bundle builder. Builds on top of #578, and should not be merged before that is.
Definition of Done Checklist
Author
Reviewer
Acceptance