Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy userinfofetcher regorules #580
base: spike/bundle-builder-v2
Are you sure you want to change the base?
Deploy userinfofetcher regorules #580
Changes from all commits
2484b77
1c74f89
22ba466
7174021
dda07d2
9150db1
7cd4db0
a529195
232fd64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check notice on line 92 in docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc
GitHub Actions / LanguageTool
[LanguageTool] docs/modules/opa/pages/usage-guide/user-info-fetcher.adoc#L92
Raw output
Check failure on line 13 in rust/regorule-library/README.md
GitHub Actions / markdownlint
[markdownlint] rust/regorule-library/README.md#L13
Raw output
Check failure on line 13 in rust/regorule-library/README.md
GitHub Actions / markdownlint
[markdownlint] rust/regorule-library/README.md#L13
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to mention that we other examples where we assert on the return code and don't use
raise_error
:https://github.com/stackabletech/demos/blob/61601f8ed879c4e8ba0766ec0fe0320ee959bdb7/stacks/end-to-end-security/trino-policies.yaml#L176-L184
I don't have any preference, but other ones might have and we should agree on one.