refactor!: Remove legacy node selector on RoleGroup

[sbernauer]

Description

Remove deprecated code from #556.
Users had enough time to migrate

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

Edit tasklist title

Beta Give feedback Tasklist Author, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Changes are OpenShift compatible

   Changes are OpenShift compatible
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. CRD changes approved

   CRD changes approved
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Integration tests passed (for non trivial changes)

   Integration tests passed (for non trivial changes)
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Author

Reviewer

Edit tasklist title

Beta Give feedback Tasklist Reviewer, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Code contains useful comments

   Code contains useful comments
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. (Integration-)Test cases added

   (Integration-)Test cases added
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Documentation added or updated

   Documentation added or updated
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Changelog updated

   Changelog updated
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Cargo.toml only contains references to git tags (not specific commits or branches)

   Cargo.toml only contains references to git tags (not specific commits or branches)
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Reviewer

Acceptance

Edit tasklist title

Beta Give feedback Tasklist Acceptance, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Feature Tracker has been updated

   Feature Tracker has been updated
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Proper release label has been added

   Proper release label has been added
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Acceptance

[maltesander]

Thanks, LGTM! But i would bet we have it in some other operators / examples (e.g. https://github.com/stackabletech/opa-operator/blob/9c8c3bbdcf731b2f2d4f6af67bec1044c64ce56d/tests/templates/kuttl/smoke/10-install-opa.yaml.j2#L37C9-L38C23). Might be worth doing a grep on all repos?

[sbernauer]

Regarding the grep: Totally agreed, did that on the docs repo: stackabletech/documentation#453.
Also have added an checklist item to do it for all the operators once we bump them

[sbernauer]

Lets wait for Arch meeting

[lfrancke]

@sbernauer Can you tell me what happened with this one? It has the 23.11 label but is not actually included.

[fhennig]

Maybe @maltesander can chime in?

[maltesander]

Yeah we can remove the label since this is not in 23.11.
Otherwise the PR looks good, whenever i saw the labelselector in tests / examples i already removed it but probably a last check before merging this (or bumping the operators to a new tag) should be done / tracked.

[lfrancke]

I'll add it to the board as it seems to be basically done

[sbernauer]

Yeah, PR is good to merge. I wasn't allowed to merge before because of priority reasons ;)

[NickLarsenNZ]

I approve the intention 👍