[Merged by Bors] - Add support for Black Hole connector #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
reviewed
Nov 25, 2022
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
|
Honestly i think it's fine as Trino doesn't support multiple coordinators as of now |
Yeah but that may change in the future? |
|
But in that case the blackhole connector might supports it as well ;) Mentioned it anyway ;) |
|
thx! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
# Description ## Review Checklist - [x] Code contains useful comments - [ ] CRD change approved (or not applicable) - [ ] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information