-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add support for Black Hole connector #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
Should we mention in the docs that this does not work for HA:
This connector does not work properly with multiple coordinators, since each coordinator has different metadata.
?
Co-authored-by: Malte Sander <contact@maltesander.com>
Co-authored-by: Malte Sander <contact@maltesander.com>
Honestly i think it's fine as Trino doesn't support multiple coordinators as of now |
Yeah but that may change in the future? |
But in that case the blackhole connector might supports it as well ;) Mentioned it anyway ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thx! |
bors r+ |
# Description ## Review Checklist - [x] Code contains useful comments - [ ] CRD change approved (or not applicable) - [ ] (Integration-)Test cases added (or not applicable) - [x] Documentation added (or not applicable) - [x] Changelog updated (or not applicable) - [x] Cargo.toml only contains references to git tags (not specific commits or branches) - [x] Helm chart can be installed and deployed operator works (or not applicable) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
Pull request successfully merged into main. Build succeeded: |
Description
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information