-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Consolidate global cluster config #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comment, no complete review.
Any particular reason you did go with
tls:
server:
secretClass: tls
quorum:
secretClass: tls
instead of
tls:
serverSecretClass: secret_class # Option<String>. *In general* defaults to "tls"
internalSecretClass: secret_class # Option<String>. *In general* defaults to "tls"
It basically was like this for server, i did the same for quorum. I thought about just using the String and like it better as well. Happy to change this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
test for latest changes: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/33/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Can you test if the getting started guide still works? |
For the record: Spoke to Malte and we agreed that the |
…uster-config # Conflicts: # examples/simple-zookeeper-tls-cluster.yaml
…g' into consolidate-global-cluster-config
bors merge |
# Description The new structure now looks like: ``` apiVersion: zookeeper.stackable.tech/v1alpha1 kind: ZookeeperCluster metadata: name: simple-zk spec: image: productVersion: 3.8.0 stackableVersion: 0.8.0 clusterConfig: authentication: - authenticationClass: zookeeper-tls-authentication-class (with provider tls) # String tls: serverSecretClass: tls quorumSecretClass: tls logging: vectorAggregatorConfigMapName: vector-aggregator-discovery servers: .... ``` fixes #596 test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/33/ Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Pull request successfully merged into main. Build succeeded: |
Description
The new structure now looks like:
fixes #596
test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/33/
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information