[Merged by Bors] - Consolidate global cluster config

[maltesander]

Description

The new structure now looks like:

apiVersion: zookeeper.stackable.tech/v1alpha1
kind: ZookeeperCluster
metadata:
  name: simple-zk
spec:
  image:
    productVersion: 3.8.0
    stackableVersion: 0.8.0
  clusterConfig:
    authentication:
      - authenticationClass: zookeeper-tls-authentication-class (with provider tls) # String
    tls:
      serverSecretClass: tls
      quorumSecretClass: tls
    logging:
      vectorAggregatorConfigMapName: vector-aggregator-discovery
  servers:
....

fixes #596

test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/33/

Review Checklist

• Code contains useful comments
• CRD change approved (or not applicable)
• (Integration-)Test cases added (or not applicable)
• Documentation added (or not applicable)
• Changelog updated (or not applicable)
• Cargo.toml only contains references to git tags (not specific commits or branches)
• Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

[sbernauer]

Just some comment, no complete review.

Any particular reason you did go with

    tls:
      server:
        secretClass: tls
      quorum:
        secretClass: tls

instead of

    tls:
      serverSecretClass: secret_class # Option<String>. *In general* defaults to "tls"
      internalSecretClass: secret_class # Option<String>. *In general* defaults to "tls"

[maltesander]

Just some comment, no complete review.

Any particular reason you did go with

    tls:
      server:
        secretClass: tls
      quorum:
        secretClass: tls

instead of

    tls:
      serverSecretClass: secret_class # Option<String>. *In general* defaults to "tls"
      internalSecretClass: secret_class # Option<String>. *In general* defaults to "tls"

It basically was like this for server, i did the same for quorum. I thought about just using the String and like it better as well. Happy to change this.

[razvan]

lgtm

[maltesander]

test for latest changes: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/33/

[razvan]

lgtm

[fhennig]

Can you test if the getting started guide still works?

[sbernauer]

For the record: Spoke to Malte and we agreed that the authentication´section needs to be changed to a Vec<> to match the description of the PR. We should include all braking changes in this PR to not have another breaking change shortly afterwards

[maltesander]

hopefully last test: https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/zookeeper-operator-it-custom/35/

[maltesander]

bors merge

[bors]

Pull request successfully merged into main.

Build succeeded:

• All tests passed