Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent workspace name for grpc-gateway #32

Closed
qzmfranklin opened this issue Dec 30, 2018 · 3 comments
Closed

inconsistent workspace name for grpc-gateway #32

qzmfranklin opened this issue Dec 30, 2018 · 3 comments

Comments

@qzmfranklin
Copy link
Contributor

The grpc-gateway repo officially uses grpc_ecosystem_grpc_gateway as the Bazel workspace name, as demonstrated here.

In github.com/grpc-ecosystem/grpc-gateway, the same repo is referenced via a different name com_github_grpc_ecosystem_grpc_gateway.

This inconsistency causes build errors for me (and likely other people too).

Admittedly, the name prefixed with com_github (i.e., the name rules_proto chose) sounds more correct to me. But I don't think it is easy to convince grpc-gateway to change the workspace name just because of this.

What's an acceptable solution here?

@pcj
Copy link
Member

pcj commented Jan 3, 2019

We should just adopt the name they chose. Happy to accept a PR or I will fix and close this issue.

@qzmfranklin
Copy link
Contributor Author

Sorry for the late reply. Created a PR to rename the workspace name as discussed.

@pcj
Copy link
Member

pcj commented Jan 6, 2019

Closed by #39

@pcj pcj closed this as completed Jan 6, 2019
alexeagle pushed a commit to alexeagle/rules_proto that referenced this issue Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants