Add starlark rule "experimental_resolve_attr" feature #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the starlark rule implementation don't support the resolve phase. This is a bit of a hack to support automatic deps resolution of same-kind rules.
sacsar
added a commit
to Nextdoor/rules_proto
that referenced
this pull request
Aug 4, 2023
* Add bazel to gitignore files * make tidy * Add proto_repositories with descriptors * make tidy * Update grpc-web to 1.4.2 (for darwin arm64) * Use grpc-gateway plugin from go_deps * Copy cmd/gazelle files over from 0.31.0 * Update @bazel_gazelle to 0.31.0 * Build all descriptors in @protoapis * Move internal packages to a location where 'go build' can find them * Add testonly flags to all_files * Sync changes for proto_gazelle * Move com_google_absl override into deps/BUILD * Code review * Fix proto_repository for @googleapis (stackb#324) * Include vendor tree in proto_repository_tools_srcs * Rename -override_go_googleapis to -reresolve_known_proto_imports * Add googleapis to CI build * Fix TestOverrideRule * proto_gazelle: support static mode (stackb#327) This is supported by the underlying gazelle, just need to update the runner script. * proto_repository: add attributes to write a proto_repository_info provider (stackb#328) * Use non-zip archive for @protoapis dep * Add proto_repository_info provider, rule, and github_proto_repository macro * Upgrade to rules_go 0.39.1 * Bump minimum bazel version to 5.4.0 * Add test for ProtoRepositoryInfo provider * Bump bazelci version * Add starlark rule "experimental_resolve_attr" feature (stackb#329) * Add starlark rule "experimental_resolve_attr" feature * Restore proto_repository_tools check * Fix errors due to hidden/swallowed starlark configuration problems! * Fix //example/golden:starlark_java_test --------- Co-authored-by: Paul Johnston <pcj@stack.build>
sacsar
added a commit
to Nextdoor/rules_proto
that referenced
this pull request
Aug 14, 2023
* Add bazel to gitignore files * make tidy * Add proto_repositories with descriptors * make tidy * Update grpc-web to 1.4.2 (for darwin arm64) * Use grpc-gateway plugin from go_deps * Copy cmd/gazelle files over from 0.31.0 * Update @bazel_gazelle to 0.31.0 * Build all descriptors in @protoapis * Move internal packages to a location where 'go build' can find them * Add testonly flags to all_files * Sync changes for proto_gazelle * Move com_google_absl override into deps/BUILD * Code review * Fix proto_repository for @googleapis (stackb#324) * Include vendor tree in proto_repository_tools_srcs * Rename -override_go_googleapis to -reresolve_known_proto_imports * Add googleapis to CI build * Fix TestOverrideRule * proto_gazelle: support static mode (stackb#327) This is supported by the underlying gazelle, just need to update the runner script. * proto_repository: add attributes to write a proto_repository_info provider (stackb#328) * Use non-zip archive for @protoapis dep * Add proto_repository_info provider, rule, and github_proto_repository macro * Upgrade to rules_go 0.39.1 * Bump minimum bazel version to 5.4.0 * Add test for ProtoRepositoryInfo provider * Bump bazelci version * Add starlark rule "experimental_resolve_attr" feature (stackb#329) * Add starlark rule "experimental_resolve_attr" feature * Restore proto_repository_tools check * Fix errors due to hidden/swallowed starlark configuration problems! * Fix //example/golden:starlark_java_test --------- Co-authored-by: Paul Johnston <pcj@stack.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new attribute to the starlark rule struct implementation
experimental_resolve_attrthat, if provided with a string attribute name such asdeps, will perform a default logic for deps resolution. The deps will mirror the deps structure of the underlyingproto_library, but for the same rule kind.This is a bit of a hack; a proper implementation would expose the RuleIndex and other bits typically needed to do custom implementations of the resolve phase.
In preparing this PR it was was discovered that the starlark configuration loading phase was swallowing errors; fixing this triggered fixing a few unrelated starlark errors that had been lurking in the codebase.