Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel 6.4.0, rules_go v0.45, bazel-gazelle 0.35, more... #355

Merged
merged 49 commits into from Feb 13, 2024

Conversation

pcj
Copy link
Member

@pcj pcj commented Jan 3, 2024

This is a large PR that includes:

  • use bazel to 6.4.0 (was 5.4.0)
  • add github actions CI. bazelci continues to run, but the default branch has not been updated in years and it is difficult to find a bazel core contrib to manage bazelci for external repos.
  • migrates //external:BUILD.bazel to use the (new) yaml config file //:rules_proto_config.yaml, which works as a default config for stackb/rules_proto consumers.
  • migrates //:gazelle target in this repository to use proto_gazelle, referencing the imports from other proto_repository rules.
  • the javascript plugin --js_out is no longer bundled with protoc. A new dependency to protocolbuffers/protobuf-javascript added. New top-level js_core_deps.bzl macro.
  • WORKSPACE re-org
  • vendored google/protobuf/timestamp.proto until ts_proto can deal correctly with external repositories.
  • bumped go.mod go version to 1.18
  • upgraded go deps
  • updated pkg/protoc/resolver.go to deal with feat(resolve): optimize applying overrides to be efficient bazelbuild/bazel-gazelle#1687.

Upgrades:

  • bazelbuild/io_bazel_rules_go upgraded from 0.39.1 to 0.44.1
  • bazelbuild/bazel_gazelle upgraded from 0.31.0 to 0.35.0
  • bazelbuild/rules_proto upgraded to f9b0b880d1e10e18daeeb168cef9d0f8316fdcb5 (latest)
  • protocolbuffers/protobuf upgraded from 3.20.1 to v21.12. NOTE: The protobuf-javascript repo is stuck on v21 and needs to be migrated to use selected abseil imports rather than older imports that were previously vendored into protobuf repo.
  • grpc/grpc upgraded from 1.54.1 to 1.54.3
  • grpc-web upgraded from 1.4.2 to 1.5.0

@pcj pcj force-pushed the update-deps-and-use-yaml-config-file branch from de8f383 to a96563d Compare January 25, 2024 23:40
@pcj pcj changed the title Update deps and use yaml config file bazel 6.4.0, rules_go v0.45, bazel-gazelle 0.35, more... Feb 13, 2024
@pcj pcj mentioned this pull request Feb 13, 2024
@pcj pcj merged commit ee01b60 into master Feb 13, 2024
1 check passed
@pcj pcj deleted the update-deps-and-use-yaml-config-file branch February 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant