Support for gazelle 0.35.0 #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vihangm
force-pushed
the
gazelle_0.35.0
branch
2 times, most recently
from
812983b
to
fbc3bc8
Compare
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
vihangm
force-pushed
the
gazelle_0.35.0
branch
from
fbc3bc8
to
cb5400d
Compare
|
@pcj Can we merge this? |
|
Just as another data point we are using this patch and it's working great for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of gazelle updated how the overrides are stored. This ensures that rules_proto works with gazelle 0.35.0
Note that this is a breaking change and makes rules_proto incompatible with older versions of gazelle.
Fixes #356