Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save is not working-bug #357

Closed
AnuHejamady opened this issue Mar 22, 2018 · 34 comments
Closed

Save is not working-bug #357

AnuHejamady opened this issue Mar 22, 2018 · 34 comments

Comments

@AnuHejamady
Copy link

I have to rewrite the code once written as opening the site opens the application that was created initially and new code added is not saved.

@seveves
Copy link
Collaborator

seveves commented Mar 22, 2018

@AnuHejamady thank you for your issue but I have problems in understanding the workflow needed to reproduce this behavior. Could you break this down a bit further and explain it to me?

@erikwco
Copy link

erikwco commented Apr 3, 2018

I face the same problem today I worked about four hours and all was fine, every file is saved, compiled and tested (is an Angular project by the way) then when I close the browser go to home to continue in the night, my surprise when open the editor again the code has reversed or lost for about 2 hours of work.

I hope this helps. by the moment, I will download the code and work locally, I can not afford to lose the code again.

Edit:
I realize that the code recovered was up to the last export I made, after the export the code was lost

@EricSimons
Copy link
Member

Can you link the project(s) in question? Our save logic is pretty robust, very very unlikely that your code isn’t being persisted. Potentially an issue w/ your browser cache?

@erikwco
Copy link

erikwco commented Apr 3, 2018

Of course the project is: https://stackblitz.com/edit/angular-wsazse

In the lapse of time that I worked in the project today, I didn't clean the cache browser on any way, only work on the editor and tested in a separated tab.

@EricSimons
Copy link
Member

@erikwco looking at our logs now- it appears you were actively using the editor from ~12pm to 5:30pm, then came back around 9pm. Does that sound right? (Making sure that the window from 5:30-9 was actually lack of usage and not persistence blackout)

Also, did you drag & drop any files into the editor at any point?

Further, do you have any chrome extensions enabled (i.e. adblock, etc)? Sometimes these can cause similar problems.

@erikwco
Copy link

erikwco commented Apr 3, 2018

@EricSimons, yesterday I ended my turn around 6:45pm to 7:00pm, thats show a lack of 1 and a half hour approx, I cannot tell exactly this is the time I lost but it can be, I can not either assure but I think 5:30 is the time when I made the first export of the app to local.

In my browser I have the follow extensions installed:

  • Chromecast
  • LightHouse
  • Unsplah Instant
  • Site Pallette
  • Evernote
  • Keep
  • SidePlayer
  • McAfee Web Advisor

Usually don't have any kind of adblocker, but if you think some of the installed extension might cause the trouble I can uninstall them and test again to try to reproduce the error.

@cec
Copy link

cec commented Jul 9, 2018

Hi,

I have a similar issue, except I can't save ever...

Here is an empty project created with the Angular Project button in homepage

In Chrome's inspector I see the following error in console:

PATCH https://stackblitz.com/api/projects/angular-uuudmp 0 ()

Stacktrace and request's payload are attached.

This error presents itself when operating inside our corporate network.
Could it be that you guys are actually never receiving the request? (AKA our firewall is blocking the request)

N.B.: all Chrome extensions are disabled.

stacktrace.txt

payload.json.txt

Thank you!

@bcmedeiros
Copy link

Same problem here, I hit the save button, it seems to start doing something, but then the button shows up as available again and if I try to open the same project in another browser, it's not saved at all.

No error message is shown.

It also refuses me to rename the project to any name, saying it's being taken already, even being a sha1 hash.

Same browser version works in a different computer, so I'm suspecting it's related to the company proxy somehow.

@panduranga007
Copy link

I am facing the same issue I have done a small react project and made updates to it since some days but everyday I need to rewrite the code.

Please fix this issue.

@EricSimons
Copy link
Member

@panduranga007 can you upload an image of your console & network tab after hitting save? Also, do you have any adblockers on? In rare cases they'll cancel the network request we make to persist your project

@cec
Copy link

cec commented Jan 29, 2019

@EricSimons could you provide me with some feedback on my case as well?

I already provided the stacktrace in the console and other info.

Thank you

@EricSimons
Copy link
Member

@cec I'm sorry, I totally missed yours and @brunojcm's comments! Just looked at trace & payload- it def looks like we're never receiving the requests, which would point at a firewall issue. Very curious why that's the case though 🤔

@miltonhowe
Copy link

miltonhowe commented Feb 5, 2019

I am having the same issue. I started an (Angular) project, made a bunch of changes over several days, including uploading a bunch of files, without ever closing the browser (Chrome). It runs perfectly in the initial browser window. If I try to open it in any other window, it reverts to the skeleton of the project which was created, with none of my changes, new files, new folders, new dependencies, nothing.

I.E. if I cut-and-paste the URL from the working tab to a new tab, it shows the project scaffolded as it was before I touched a single thing.

If I look in the console, there are a whole bunch of errors including 422 errors which I have never seen before.

@miltonhowe
Copy link

I am having the same issue. I started an (Angular) project, made a bunch of changes over several days, including uploading a bunch of files, without ever closing the browser (Chrome). It runs perfectly in the initial browser window. If I try to open it in any other window, it reverts to the skeleton of the project which was created, with none of my changes, new files, new folders, new dependencies, nothing.

I.E. if I cut-and-paste the URL from the working tab to a new tab, it shows the project scaffolded as it was before I touched a single thing.

If I look in the console, there are a whole bunch of errors including 422 errors which I have never seen before.

UPDATE: After searching the issues I found this one and I diagnosed the problem as being that my project was attempting to save binary files. This is apparently not supported and fails silently. Removing the binary files solves the saving issue. And using DataURLs works around the missing binaries.

@miltonhowe
Copy link

To clarify, for several hours I experienced the same problem as @brunojcm - hitting save greyed out the save button, which after a time returned to normal -- all normally an indication of a successful save.

The call to save was however failing, but the UI was swallowing the error without reporting it to the user. This is highly unintuitive and has clearly cost some people many hours of work. I was fortunate in that I kept the browser window open until I ultimately identified and solved my problem. Others no doubt have been less fortunate. The save function needs to examine the response and alert the reader to a failed call.

@Kay2dan
Copy link

Kay2dan commented Feb 6, 2019

I just lost a few hours of code. When I shared the link to the demo, there was nothing other than the initial code base. I did have image files though they were not being used after reading about images not being well supported in projects. I had converted to binary64. Most frustrating & I wonder whether there is a revision feature built-in?

@Nagasai-Aytha
Copy link

On clicking save, getting same error - PATCH https://stackblitz.com/api/projects/angular-r2wghb net::ERR_EMPTY_RESPONSE
Always have issue with save

@blemoine167
Copy link

blemoine167 commented May 12, 2019

Same here, save doesn't save. I dont have any PATCH error, in fact i don't have any request going when hitting (cmd+S), however the icon is changing at the top of the file window letting me think all is fine. I'm on Mac os x Chrome 74.0.3729.131.
To save my code (after having lost it twice..) I opened the project in another browser (Brave) then copy paste each of my modified files then saved ... it send a PATCH request to my project url and all was fine.

@jgrandydev
Copy link

I was coding the Angular starter app https://angular.io/start here https://stackblitz.com/angular/lrageyqaexo and ran into a problem with browser font sizes so I closed the window thinking my work was saved but it was not. I do not see any save button.

@bcmedeiros
Copy link

bcmedeiros commented Jun 13, 2019

@EricSimons said:

@cec I'm sorry, I totally missed yours and @brunojcm's comments! Just looked at trace & payload- it def looks like we're never receiving the requests, which would point at a firewall issue. Very curious why that's the case though thinking

I got bitten by this problem again today, so I did some further investigation. I realised that the operations that are failing to me are all PATCH operations, which is a, let's say, less orthodox operation, so I checked the console request log. That's what I saw:

image

Comparing with a different computer, on a different network, similar PATCH requests got a 204 response instead of a 200. Also, column Type in the failing host is empty, whereas in the working one it is filled with 'xml' (even though content looks like a json).

I tend to believe now that my proxy is messing with the PATCH request is some way, even before sending it, maybe, and returning a premature 200. Well, that is as far as I could go here.

I hate to say that, but I'm saying anyway: We probably should avoid using the PATCH verb for such an important thing as saving data. I could easily find some people expressing their concerns with this method, like here, here and here.

Would you consider migrating these operations (mainly rename and save) to a POST endpoint, for safety and compatibility's sake?

EDIT: Even if the answer to the question above is no, and considering that the interface expects a 204 when the content is successfully saved, I believe you should show a stronger error message for any other return code, like the 200 I got, if that means data might not have been saved. The wasted hour's toll here seems very high, and we are not even considering other possible related issues like #432 and people that simply stop using stackblitz (or any other tool) instead of reporting a bug when they fail badly like that.

@bernatgy
Copy link

This happened to me right now.................. lots of work went to the void. FIX NEEDED ASAP.

Mine was: https://stackblitz.com/edit/angular-q8j5yb

@DragonForest
Copy link

I had this problem just now. Lost 15 hours worth of work.

[https://stackblitz.com/edit/angular-ghxtvh]

@EricSimons
Copy link
Member

@DragonForest are there any errors happening in your console?

@DragonForest
Copy link

DragonForest commented Oct 9, 2019 via email

@bunda3d
Copy link

bunda3d commented Jan 20, 2020

Having this save-not-working issue. I had saved and committed several times on a little angular app. then there's no trace of my progress, not on github nor on stackblitz. I do not understand what the save and commit buttons are for if they're not working either at stackblitz nor github (figured there would at least be a redundancy there, but there was nothing anywhere.

Not the end of the world, just doing some basic stuff, but would like to have my progress back if you have it. angular-kris-cart was the name of the project.

@bcmedeiros
Copy link

#357 (comment)

My post still remains true for me in some networks, it seems nobody cares that much. Fair enough, if the problem is really caused by a buggy proxy/router messing up with the PATCH request. Maintainers could easily avoid that, though, (I had to change some apps of mine because some clients were complaining about operations using PATCH returning weird results) so I wonder what an official position from the Stackblitz developers would look like in regards to this issue.

@bergamin
Copy link

I'm having this problem right now. I'll have to share a screenshot of it in a SO answer because the link won't work.

This is the link: https://stackblitz.com/edit/angular-ae7cfr

This is what I was expecting but won't happen:
image

@bergamin
Copy link

I think this might be the same issue as #215

@cec
Copy link

cec commented Apr 23, 2020

Sorry for ghosting this comment thread.

@brunojcm I definiltely agree with your comment

@EricSimons I will check again with our networking department on the blocked requests

@bergamin
Copy link

It seems my example is working now

@purplem1lk
Copy link
Collaborator

Thank you for your patience - We are launching new core technology into beta this month that should resolve this issue so this will be closed accordingly. If this issue persists, feel free to tag me or ask to reopen this issue with screenshots of the error. Thank you! :)

@davidtlee
Copy link

@purplem1lk it seems like this issue still exists. I did a screen recording so you can see it (with the web inspector open so you can see console errors). This is for the Stackblitz ID: angular-ivy-ywgqjk.

stackblitz-not-saving.mov

@gestok
Copy link

gestok commented Sep 21, 2022

I just got my code overwritten from my github repo which apparently was not kept updated from stackblitz. I lost many hours of code. I wrote new code like 24hours ago, went home and wrote more (like 10hours ago). Now, my code is older than the 24hour one. It's almost at the initial state. I paid for a membership and the lack of version control, not to mention the fact that save is just not working, is very bad.

@wpitallo
Copy link

wpitallo commented Dec 3, 2022

I think this needs to be reopened just happend to as well.. all my stuff gone... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests