feat(core)!: Implement floating UI for tooltip positioning and styling #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
reviewed
Aug 16, 2023
package/src/lib/components/tour-overlay/shapes/CircleShape.component.tsx
Show resolved
Hide resolved
well1791
reviewed
Aug 16, 2023
JoseLion
pushed a commit
that referenced
this pull request
Sep 11, 2023
#108) BREAKING CHANGE: Refactored how tooltips can be positioned relative to the spot using FloatingUI. This change replaces the `alignTo` and `position` props of the SpotlightTourProvider and TourStep with `floatingProps`. The new prop lets you configure the behavior of FloatingUI for your tooltips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Floating UI in order to handle tooltip position which was having issues on IPad screens. This implementation delegates alignment and positioning to floating UI this way the user can configure floating library for each tourstep or provide a global configuration in order to show the tooltip in different positions, provide offsets, add floating middlewares,etc.