Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SportlightTourProvider ref type is not exposed to the library #15

Closed
JoseLion opened this issue Sep 7, 2020 · 1 comment · Fixed by #16
Closed

SportlightTourProvider ref type is not exposed to the library #15

JoseLion opened this issue Sep 7, 2020 · 1 comment · Fixed by #16
Assignees
@JoseLion
Labels
bug Something isn't working released

Comments

@JoseLion
Copy link
Member

JoseLion commented Sep 7, 2020

After some pairing with @rojasTob and @lopenchi we noticed that the type of the prop ref on the SportlightTourProvider component is not exposed to the library. We need to expose this so TS users can consistently declare a useRef<..>() in their code
@JoseLion JoseLion added the bug Something isn't working label Sep 7, 2020
@JoseLion JoseLion self-assigned this Sep 7, 2020
JoseLion added a commit that referenced this issue Sep 7, 2020
@JoseLion
Expose SpotlightTourProvider ref type
fa09b40 
Resolver #15
JoseLion added a commit that referenced this issue Sep 7, 2020
@JoseLion
Expose SpotlightTourProvider ref type
6542ae6 
Resolves #15
@JoseLion JoseLion mentioned this issue Sep 7, 2020
Merged
JoseLion added a commit that referenced this issue Sep 7, 2020
@JoseLion
Expose SpotlightTourProvider ref type (#16)
cfcb119 
Resolves #15
@JoseLion
Copy link
Member Author

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoseLion JoseLion

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose SpotlightTourProvider ref type stackbuilders/react-native-spotlight-tour
1 participant
@JoseLion