Add a date selector to the search function #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's because the search button triggers Make sense? |
|
Yeah, that makes sense. I was thinking |
rleed
force-pushed
the
date-selector
branch
5 times, most recently
from
b47cfc4
to
99c6aae
Compare
|
The code for this looks simple and good but the UI is too bad on mobile to ship. Going to drop in draft until you or I can fix that. |
…into date-selector
|
Updated to wrap (only) the date selector on mobile.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this in draft state (pertaining to issue #410) because I've gotten stuck and I want to ask if someone has insight on what I'm missing.
I've added the date picker to the UI in this PR, and it works fine up to and including updating the
valuesobject and the query parameters in the location bar. However, when clicking the search button to actually perform the search, thevaluesrevert back to what seem to be the initial values, and I do not understand why or where those are coming from.Does anyone have insight on why that is happening?