Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty push notifications #571

Merged
merged 1 commit into from Oct 21, 2023

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Oct 17, 2023

Fixes #568

2023-10-18.01-52-10.mp4

@ekzyis ekzyis added the bug label Oct 17, 2023
@huumn huumn merged commit ebbecdf into stackernews:master Oct 21, 2023
1 check passed
@ekzyis
Copy link
Member Author

ekzyis commented Oct 24, 2023

Mhh, this is still happening on https://stacker.news

you can test by enabling push notifications for forwarded sats and then anon zapping an item twice for which sats are forwarded to you.

@ekzyis
Copy link
Member Author

ekzyis commented Oct 24, 2023

Ah, oh, there must have been a rebase mistake or something else somewhere since the change was lost somehow. FORWARDEDTIP is no longer mentioned in the service worker on master

@ekzyis ekzyis mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty push notifications
3 participants