-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-1039] Pull retag push fix #129
Conversation
g0rgamesh
commented
Sep 9, 2022
•
edited
Loading
edited
- changed pull location to new one in quay.io
- changed tag naming to correct one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the typo in the commit message. Maybe add a small description.
Add that it closes #126
a0fd78b
to
c67354f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of adding this new information to the commit rather than the PR.
0af7c59
to
38a1f79
Compare
38a1f79
to
d402279
Compare
@@ -80,24 +80,24 @@ | |||
- name: Pull container images (may take a long time) | |||
become: true | |||
vars: | |||
remote_image: "{% if docker_pull_registry != '' %}{{ docker_pull_registry }}/{% endif %}{{ docker_pull_namespace }}/{{ item }}:{{ docker_pull_tag }}" | |||
remote_image: "{% if docker_pull_registry != '' %}{{ docker_pull_registry }}/{% endif %}{{ docker_pull_namespace }}/{{ item }}:{{ docker_pull_tag }}-{{ kolla_base_distro }}-{{ ansible_facts.distribution_release }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think ansible_facts.distribution_release is always correct here. For example, on CentOS stream the image suffix is stream8
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would ansible_distribution_release
be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just a different way of accessing the same thing. Here's how kolla-ansible does it: