Update vault haproxy template #1047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgoddard
requested changes
Apr 24, 2024
Comment on lines
112
to
113
| # 501: not initialised (required for bootstrapping) | ||
| # 503: sealed (required for bootstrapping) |
There was a problem hiding this comment.
I'd like to see a successful multinode deployment with this because I remember explicitly needing 501/503 (as mentioned in these comments), and not wanting 429 to avoid hitting backup vaults.
There was a problem hiding this comment.
I think @mnasiadka suggested that the bootstrapping is done via the ip of the node as opposed to using the vip. But I will try and do this in a multinode and update this PR
Comment on lines
112
to
113
| # 501: not initialised (required for bootstrapping) | ||
| # 503: sealed (required for bootstrapping) |
There was a problem hiding this comment.
These comments should be removed if we remove 501/503.
markgoddard
reviewed
Jun 7, 2024
There was a problem hiding this comment.
@technowhizz I have rolled this change into #1090 and marked you as a co-author.
|
change is in #1090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to stop alerts that are firing at client sites. This will also alert us if a vault is sealed and/or needs bootstrapping.
In the future we should look at using the built in exporters as suggested by @dougszumski