-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vault haproxy template #1047
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -108,9 +108,10 @@ Setup HAProxy config for Vault | |
option httpchk GET /v1/sys/health | ||
# https://www.vaultproject.io/api-docs/system/health | ||
# 200: initialized, unsealed, and active | ||
# 429: backup | ||
# 501: not initialised (required for bootstrapping) | ||
# 503: sealed (required for bootstrapping) | ||
Comment on lines
112
to
113
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These comments should be removed if we remove 501/503. |
||
http-check expect rstatus (200|501|503) | ||
http-check expect rstatus (200|429) | ||
|
||
{% for host in groups['control'] %} | ||
{% set host_name = hostvars[host].ansible_facts.hostname %} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a successful multinode deployment with this because I remember explicitly needing 501/503 (as mentioned in these comments), and not wanting 429 to avoid hitting backup vaults.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @mnasiadka suggested that the bootstrapping is done via the ip of the node as opposed to using the vip. But I will try and do this in a multinode and update this PR