Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vault haproxy template #1047

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/source/configuration/vault.rst
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,10 @@ Setup HAProxy config for Vault
option httpchk GET /v1/sys/health
# https://www.vaultproject.io/api-docs/system/health
# 200: initialized, unsealed, and active
# 429: backup
# 501: not initialised (required for bootstrapping)
# 503: sealed (required for bootstrapping)
Comment on lines 112 to 113
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a successful multinode deployment with this because I remember explicitly needing 501/503 (as mentioned in these comments), and not wanting 429 to avoid hitting backup vaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @mnasiadka suggested that the bootstrapping is done via the ip of the node as opposed to using the vip. But I will try and do this in a multinode and update this PR

Comment on lines 112 to 113
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments should be removed if we remove 501/503.

http-check expect rstatus (200|501|503)
http-check expect rstatus (200|429)

{% for host in groups['control'] %}
{% set host_name = hostvars[host].ansible_facts.hostname %}
Expand Down