harden: Only store registered repositories #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
changed the title
JAORMX
force-pushed
the
repo-refactor
branch
2 times, most recently
from
7c436fb
to
71797ab
Compare
JAORMX
changed the title
JAORMX
force-pushed
the
repo-refactor
branch
2 times, most recently
from
c98c3c2
to
7b13cfc
Compare
This changes the logic of the repo register to only store registered repositories as opposed to registering everything and then verifying if they're registered or not. This also uncovered that we weren't really checking for issues in registration... So, this changed that logic. This also adds a new provider called `repo-lister` which enables implementors to list repositories. This is handy for the auto-enrollment flow, which requires us to list remote repositories, compare them to the registered ones, and then enroll. We might not have auto-enrollment (webhook creation) for other providers... but it would be handy to be able to list repos so we could then build requests that manually register the repos to mediator.
rdimitrov
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic of the repo register to only store registered repositories as opposed to registering everything and then verifying if they're registered or not.
This also uncovered that we weren't really checking for issues in registration... So, this changed that logic.
This also adds a new provider called
repo-listerwhich enables implementors to list repositories. This is handy for the auto-enrollment flow, which requires us to list remote repositories, compare them to the registered ones, and then enroll.We might not have auto-enrollment (webhook creation) for other providers... but it would be handy to be able to list repos so we could then build requests that manually register the repos to mediator.