Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: subscribe to all events by default instead of allowing it to be configurable #1197

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 13, 2023

This registers mediator to receive all events by default for a repository when it's registered.
The intent is to allow users to not require a configuration at all when using medic with our SaaS.

We intend to make this configurable in the future.

lukehinds
lukehinds previously approved these changes Oct 13, 2023
Copy link
Contributor

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thankz @JAORMX

…onfigurable

This registers mediator to receive all events by default for a repository when it's registered.
The intent is to allow users to not require a configuration at all when using `medic` with our SaaS.

We intend to make this configurable in the future.
@JAORMX JAORMX merged commit a2ab312 into main Oct 13, 2023
13 checks passed
@JAORMX JAORMX deleted the all-events-for-repo branch October 13, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants