fix: update rule type descriptions to be consistent #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
JAORMX
reviewed
Oct 24, 2023
| @@ -6,13 +6,13 @@ context: | |||
| provider: github | |||
| description: Whether the protection rules apply to repository administrators | |||
| guidance: | | |||
| ## Enforce required status checks for repository administrators | |||
| Enforce required status checks for repository administrators | |||
There was a problem hiding this comment.
The original intention was to have something like:
<action>
<description>
Where would be something that the user can action on. It would be highlighted in the UI and in the CLI.
Do we want to add other means of highlighting the action?
There was a problem hiding this comment.
We already synced about what it causes, but if we have something like that it would help handle those separately -
guidance:
actions: |
Some text
guidance: |
Another text
JAORMX
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR:
##which messed up the rendering when they were used later in alertsFixes #1258